Skip to content

UI: support skipGroupAction#10250

Closed
weizhouapache wants to merge 1 commit intoapache:4.19from
weizhouapache:4.19-ui-skip-group-action
Closed

UI: support skipGroupAction#10250
weizhouapache wants to merge 1 commit intoapache:4.19from
weizhouapache:4.19-ui-skip-group-action

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Jan 23, 2025

Description

This PR fixes #7965 , by skipping actions on some IPs.

This PR also has some changes on group action to start/stop VMs, for example

  • skip Starting if VM is Running
  • skip stopping if VM is Stopped

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
Copy link
Member Author

weizhouapache commented Jan 23, 2025

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jan 23, 2025

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.14%. Comparing base (2075918) to head (d61b5b3).
Report is 59 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #10250      +/-   ##
============================================
- Coverage     15.14%   15.14%   -0.01%     
  Complexity    11278    11278              
============================================
  Files          5408     5408              
  Lines        473803   473831      +28     
  Branches      57819    57823       +4     
============================================
- Hits          71743    71741       -2     
- Misses       394039   394068      +29     
- Partials       8021     8022       +1
Flag Coverage Δ
uitests 4.30% <ø> (-0.01%) ⬇️
unittests 15.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

blueorangutan commented Jan 23, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10250 (QA-JID-526)

@weizhouapache
Copy link
Member Author

weizhouapache commented Jan 23, 2025

tested on qa

  • release Allocated IP
    image

  • start vms
    image

  • stop vms
    image

@weizhouapache weizhouapache linked an issue Jan 23, 2025 that may be closed by this pull request
The release reserved ip functionality doesn't work from the UI #7965
Closed
DaanHoogland
DaanHoogland approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@weizhouapache weizhouapache marked this pull request as ready for review January 23, 2025 12:14
@github-actions
Copy link

github-actions bot commented Feb 26, 2025

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@weizhouapache
Copy link
Member Author

weizhouapache commented Feb 28, 2025

closing this PR as the issue seems to be fixed by #10351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:UI status:has-conflicts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The release reserved ip functionality doesn't work from the UI

3 participants

@weizhouapache @blueorangutan @DaanHoogland